From: Michal Nowak <mnowak@isc.org>
Date: Wed, 24 Nov 2021 15:50:57 +0000 (+0100)
Subject: Fix "array subscript is of type 'char'" on NetBSD 9
X-Git-Tag: v9.17.21~18^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d09447287f02cdf479cf2e542e4ab0efe7a024fe;p=thirdparty%2Fbind9.git

Fix "array subscript is of type 'char'" on NetBSD 9

    In file included from rdata.c:602:
    In file included from ./code.h:88:
    ./rdata/in_1/svcb_64.c:259:9: warning: array subscript is of type 'char' [-Wchar-subscripts]
                            if (!isdigit(*region->base)) {
                                 ^~~~~~~~~~~~~~~~~~~~~~
    /usr/include/sys/ctype_inline.h:51:44: note: expanded from macro 'isdigit'
    #define isdigit(c)      ((int)((_ctype_tab_ + 1)[(c)] & _CTYPE_D))
                                                    ^~~~
---

diff --git a/lib/dns/rdata/in_1/svcb_64.c b/lib/dns/rdata/in_1/svcb_64.c
index 12e8caae52a..a9d65f98dad 100644
--- a/lib/dns/rdata/in_1/svcb_64.c
+++ b/lib/dns/rdata/in_1/svcb_64.c
@@ -256,7 +256,7 @@ svc_fromtext(isc_textregion_t *region, isc_buffer_t *target) {
 			RETERR(alpn_fromtxt(region, target));
 			break;
 		case sbpr_port:
-			if (!isdigit(*region->base)) {
+			if (!isdigit((unsigned char)*region->base)) {
 				return (DNS_R_SYNTAX);
 			}
 			ul = strtoul(region->base, &e, 10);