From: Timo Sirainen <tss@iki.fi>
Date: Tue, 22 Apr 2003 18:37:58 +0000 (+0300)
Subject: Give BAD instead of NO when trying to use selected state command in
X-Git-Tag: 1.1.alpha1~4729
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d0ace4ae50ab2fd4c07a4d2d018cd3dd89572ddc;p=thirdparty%2Fdovecot%2Fcore.git

Give BAD instead of NO when trying to use selected state command in
non-selected state.

--HG--
branch : HEAD
---

diff --git a/src/imap/commands-util.c b/src/imap/commands-util.c
index f067bbd440..c1c04949bf 100644
--- a/src/imap/commands-util.c
+++ b/src/imap/commands-util.c
@@ -86,21 +86,25 @@ int client_verify_open_mailbox(struct client *client)
 	if (client->mailbox != NULL)
 		return TRUE;
 	else {
-		client_send_tagline(client, "NO No mailbox selected.");
+		client_send_tagline(client, "BAD No mailbox selected.");
 		return FALSE;
 	}
 }
 
 void client_sync_full(struct client *client)
 {
-	if (client->mailbox != NULL)
-		(void)client->mailbox->sync(client->mailbox, TRUE);
+	if (client->mailbox != NULL) {
+		if (!client->mailbox->sync(client->mailbox, TRUE))
+                        client_send_untagged_storage_error(client);
+	}
 }
 
 void client_sync_without_expunges(struct client *client)
 {
-	if (client->mailbox != NULL)
-		(void)client->mailbox->sync(client->mailbox, FALSE);
+	if (client->mailbox != NULL) {
+		if (!client->mailbox->sync(client->mailbox, FALSE))
+			client_send_untagged_storage_error(client);
+	}
 }
 
 void client_send_storage_error(struct client *client)