From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Date: Sun, 12 Jun 2022 18:51:41 +0000 (+0200)
Subject: sd-id128: avoid an unnecessary function call in inline helper
X-Git-Tag: v252-rc1~741^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d0aec7d4daa0670411613de4e9c3cd444a8a216f;p=thirdparty%2Fsystemd.git

sd-id128: avoid an unnecessary function call in inline helper

When optimizing, the compiler will most likely replace the call to memcmp(),
but at -O0, the code that is emitted builds the call preamble and does the
call. Let's use the same pattern as with sd_id128_is_null() and
sd_id128_is_allf() and avoid the call.
---

diff --git a/src/systemd/sd-id128.h b/src/systemd/sd-id128.h
index f7d3244bb38..2aa41623cef 100644
--- a/src/systemd/sd-id128.h
+++ b/src/systemd/sd-id128.h
@@ -116,7 +116,7 @@ int sd_id128_get_boot_app_specific(sd_id128_t app_id, sd_id128_t *ret);
         #a #b #c #d "-" #e #f "-" #g #h "-" #i #j "-" #k #l #m #n #o #p
 
 _sd_pure_ static __inline__ int sd_id128_equal(sd_id128_t a, sd_id128_t b) {
-        return memcmp(&a, &b, 16) == 0;
+        return a.qwords[0] == b.qwords[0] && a.qwords[1] == b.qwords[1];
 }
 
 _sd_pure_ static __inline__ int sd_id128_is_null(sd_id128_t a) {