From: Christian Brauner <christian.brauner@ubuntu.com>
Date: Tue, 5 Feb 2019 22:50:43 +0000 (+0100)
Subject: compiler: -Wnested-externs hardening
X-Git-Tag: lxc-3.2.0~165^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d0afbad9a4bb5db59de4f6fdc54e6b270b48bffa;p=thirdparty%2Flxc.git

compiler: -Wnested-externs hardening

Warn if an extern declaration is encountered within a function.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
---

diff --git a/configure.ac b/configure.ac
index 664ce9b1c..8313b18d1 100644
--- a/configure.ac
+++ b/configure.ac
@@ -718,6 +718,7 @@ AX_CHECK_COMPILE_FLAG([-fdiagnostics-show-option], [CFLAGS="$CFLAGS -fdiagnostic
 AX_CHECK_COMPILE_FLAG([-Werror=shift-count-overflow], [CFLAGS="$CFLAGS -Werror=shift-count-overflow"],,[-Werror])
 AX_CHECK_COMPILE_FLAG([-Werror=shift-overflow=2], [CFLAGS="$CFLAGS -Werror=shift-overflow=2"],,[-Werror])
 AX_CHECK_COMPILE_FLAG([-Wdate-time], [CFLAGS="$CFLAGS -Wdate-time"],,[-Werror])
+AX_CHECK_COMPILE_FLAG([-Wnested-externs], [CFLAGS="$CFLAGS -Wnested-externs"],,[-Werror])
 
 AX_CHECK_LINK_FLAG([-z relro], [LDLAGS="$LDLAGS -z relro"],,[])
 AX_CHECK_LINK_FLAG([-z now], [LDLAGS="$LDLAGS -z now"],,[])
diff --git a/src/tests/lxc-test-utils.c b/src/tests/lxc-test-utils.c
index d0c07dc59..4f7950ce8 100644
--- a/src/tests/lxc-test-utils.c
+++ b/src/tests/lxc-test-utils.c
@@ -38,6 +38,7 @@
 #include <sys/types.h>
 #include <unistd.h>
 
+#include "confile_utils.h"
 #include "lxctest.h"
 #include "macro.h"
 #include "utils.h"
@@ -519,8 +520,6 @@ void test_parse_byte_size_string(void)
 
 void test_lxc_config_net_hwaddr(void)
 {
-	bool lxc_config_net_hwaddr(const char *line);
-
 	if (!lxc_config_net_hwaddr("lxc.net.0.hwaddr = 00:16:3e:04:65:b8\n"))
 		exit(EXIT_FAILURE);