From: Han Zhu <zhuhan7737@gmail.com>
Date: Tue, 19 Jul 2022 20:55:48 +0000 (-0700)
Subject: [largeNbDicts] Fix decompression segfault in createCompressInstructions
X-Git-Tag: v1.5.4^2~187^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d0c88afe6d5c0a29274df735a044154c6bf6deaa;p=thirdparty%2Fzstd.git

[largeNbDicts] Fix decompression segfault in createCompressInstructions

Benchmarking decompression results in a segfault in `createCompressInstructions`
because `cctxParams` is NULL. Skip running that function if we are not benching
compression.
---

diff --git a/contrib/largeNbDicts/largeNbDicts.c b/contrib/largeNbDicts/largeNbDicts.c
index 66850e28c..f1a80c8e1 100644
--- a/contrib/largeNbDicts/largeNbDicts.c
+++ b/contrib/largeNbDicts/largeNbDicts.c
@@ -670,7 +670,9 @@ static int benchMem(slice_collection_t dstBlocks,
             BMK_createTimedFnState(total_time_ms, ms_per_round);
 
     decompressInstructions di = createDecompressInstructions(ddictionaries);
-    compressInstructions ci = createCompressInstructions(cdictionaries, cctxParams);
+    compressInstructions ci;
+    if (benchCompression)
+      ci = createCompressInstructions(cdictionaries, cctxParams);
     void* payload = benchCompression ? (void*)&ci : (void*)&di;
     BMK_benchParams_t const bp = {
         .benchFn = benchCompression ? compress : decompress,