From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Wed, 15 Sep 2021 19:08:13 +0000 (-0500)
Subject: Don't do direct comparison with pointer
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d0d73ea48839acf08c25b3296414e01168557229;p=thirdparty%2Ffreeradius-server.git

Don't do direct comparison with pointer
---

diff --git a/src/lib/server/state.c b/src/lib/server/state.c
index cf8355ab340..65ad35efd83 100644
--- a/src/lib/server/state.c
+++ b/src/lib/server/state.c
@@ -678,7 +678,7 @@ int fr_state_to_request(fr_state_tree_t *state, request_t *request)
    	PTHREAD_MUTEX_UNLOCK(&state->mutex);
 
 	/* Probably impossible in the current code */
-	if (unlikely(entry->thawed)) {
+	if (unlikely(entry->thawed != NULL)) {
 		RERROR("State entry has already been thawed by a request %"PRIu64, entry->thawed->number);
 		PTHREAD_MUTEX_UNLOCK(&state->mutex);
 		return -2;