From: Pauli <pauli@openssl.org>
Date: Mon, 29 Mar 2021 02:29:10 +0000 (+1000)
Subject: x509: fix coverity 1474470: NULL pointer dereference
X-Git-Tag: openssl-3.0.0-alpha14~92
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d0ea0eb331176bf5882e31c8cf2538af16ef76cb;p=thirdparty%2Fopenssl.git

x509: fix coverity 1474470: NULL pointer dereference

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/14716)
---

diff --git a/crypto/x509/x509_att.c b/crypto/x509/x509_att.c
index 52cad9a0472..e7ed1899581 100644
--- a/crypto/x509/x509_att.c
+++ b/crypto/x509/x509_att.c
@@ -79,7 +79,7 @@ STACK_OF(X509_ATTRIBUTE) *X509at_add1_attr(STACK_OF(X509_ATTRIBUTE) **x,
 
     if (x == NULL) {
         ERR_raise(ERR_LIB_X509, ERR_R_PASSED_NULL_PARAMETER);
-        goto err2;
+        return NULL;
     }
 
     if (*x == NULL) {