From: Timo Sirainen Date: Wed, 22 Sep 2021 16:34:32 +0000 (+0300) Subject: mdbox: Add assert to help static analyzers X-Git-Tag: 2.3.18~318 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d10bc56592ed680a49e5cfa9410624fdd23dcd0a;p=thirdparty%2Fdovecot%2Fcore.git mdbox: Add assert to help static analyzers mdbox_sync_begin() can return 0 with sync_ctx=NULL, but not with the parameters given here. --- diff --git a/src/lib-storage/index/dbox-multi/mdbox-save.c b/src/lib-storage/index/dbox-multi/mdbox-save.c index ff6e4f77b0..8a614e7c51 100644 --- a/src/lib-storage/index/dbox-multi/mdbox-save.c +++ b/src/lib-storage/index/dbox-multi/mdbox-save.c @@ -310,6 +310,7 @@ int mdbox_transaction_save_commit_pre(struct mail_save_context *_ctx) mdbox_transaction_save_rollback(_ctx); return -1; } + i_assert(ctx->sync_ctx != NULL); /* assign map UIDs for newly saved messages after we've successfully acquired all the locks. the transaction is now very unlikely to