From: Victor Julien <vjulien@oisf.net>
Date: Fri, 27 Jan 2023 19:30:20 +0000 (+0100)
Subject: flowworker: don't keep unnecessary flow reference
X-Git-Tag: suricata-6.0.11~67
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d13bb7f5a7e02e51e7628ae92bb4f4e8be12db69;p=thirdparty%2Fsuricata.git

flowworker: don't keep unnecessary flow reference

Flow stream/detect/log flush packets, don't hold on to the flow
beyond the flow worker module.

(cherry picked from commit a2dc9a40e76ded08e084f1c11eff2140380e73ec)
---

diff --git a/src/flow-worker.c b/src/flow-worker.c
index 984b81a875..3b7c69be80 100644
--- a/src/flow-worker.c
+++ b/src/flow-worker.c
@@ -390,6 +390,9 @@ static inline void FlowWorkerStreamTCPUpdate(ThreadVars *tv, FlowWorkerThreadDat
 
         OutputLoggerLog(tv, x, fw->output_thread);
 
+        /* no need to keep a flow ref beyond this point */
+        FlowDeReference(&x->flow);
+
         if (timeout) {
             PacketPoolReturnPacket(x);
         } else {