From: John Ferlan <jferlan@redhat.com>
Date: Fri, 1 Sep 2017 17:16:17 +0000 (-0400)
Subject: qemu: Remove unused params from qemuDomainDeviceDefValidate
X-Git-Tag: v3.8.0-rc1~181
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d143837bd181230719e23205554850798a1ebbfe;p=thirdparty%2Flibvirt.git

qemu: Remove unused params from qemuDomainDeviceDefValidate

Neither @cfg nor (now) @driver is used in the API, so remove them
and mark @opaque as UNUSED.

NB: Commit id 'fa3c558596' dropped the unused @qemuCaps which was the
last consumer of @driver other than @cfg, but even @cfg was never used
even in the original implementation from commit id 'd987f63a'.
---

diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index c3f8b8f8f7..9cff501006 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -3303,10 +3303,8 @@ qemuDomainRedirdevDefValidate(const virDomainRedirdevDef *def)
 static int
 qemuDomainDeviceDefValidate(const virDomainDeviceDef *dev,
                             const virDomainDef *def ATTRIBUTE_UNUSED,
-                            void *opaque)
+                            void *opaque ATTRIBUTE_UNUSED)
 {
-    virQEMUDriverPtr driver = opaque;
-    virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);
     int ret = -1;
 
     if (dev->type == VIR_DOMAIN_DEVICE_NET) {
@@ -3390,7 +3388,6 @@ qemuDomainDeviceDefValidate(const virDomainDeviceDef *dev,
 
     ret = 0;
  cleanup:
-    virObjectUnref(cfg);
     return ret;
 }