From: sgorsh Date: Sun, 9 Apr 2017 12:00:34 +0000 (+0200) Subject: Use getOwnPropertyNames to check for empty object. X-Git-Tag: 2.19.0~30^2~1 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d150dc7d026e89e042bc134b03fd69fd3e2023aa;p=thirdparty%2Fmoment.git Use getOwnPropertyNames to check for empty object. Added hasOwnProperty check to for..in loop. --- diff --git a/src/lib/utils/is-object-empty.js b/src/lib/utils/is-object-empty.js index c8c765e72..695c3d248 100644 --- a/src/lib/utils/is-object-empty.js +++ b/src/lib/utils/is-object-empty.js @@ -1,11 +1,12 @@ export default function isObjectEmpty(obj) { - if (Object.keys) { - return (Object.keys(obj).length === 0); + if (Object.getOwnPropertyNames) { + return (Object.getOwnPropertyNames(obj).length === 0); } else { var k; for (k in obj) { - // even if its not own property I'd still call it non-empty - return false; + if (obj.hasOwnProperty(k)) { + return false; + } } return true; }