From: Harald Hoyer <harald@redhat.com>
Date: Fri, 26 Mar 2021 09:29:28 +0000 (+0100)
Subject: fix(qeth_rules): shellcheck for modules.d/95qeth_rules
X-Git-Tag: 054~205
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d15441cef47e7d741923b779fef88be79e44b389;p=thirdparty%2Fdracut.git

fix(qeth_rules): shellcheck for modules.d/95qeth_rules
---

diff --git a/modules.d/95qeth_rules/.shchkdir b/modules.d/95qeth_rules/.shchkdir
new file mode 100644
index 000000000..e69de29bb
diff --git a/modules.d/95qeth_rules/module-setup.sh b/modules.d/95qeth_rules/module-setup.sh
index 8fbdcdaf2..914a28ce8 100755
--- a/modules.d/95qeth_rules/module-setup.sh
+++ b/modules.d/95qeth_rules/module-setup.sh
@@ -10,8 +10,8 @@ check() {
 
     [[ $hostonly ]] && {
         for i in /sys/devices/qeth/*/online; do
-            read _online < $i
-            [ $_online -eq 1 ] && return 0
+            read -r _online < "$i"
+            [ "$_online" -eq 1 ] && return 0
         done
     }
     return 255
@@ -25,7 +25,7 @@ installkernel() {
 # called by dracut
 install() {
     ccwid() {
-        qeth_path=$(readlink -e -q $1/device)
+        qeth_path=$(readlink -e -q "$1"/device)
         basename "$qeth_path"
     }
 
@@ -44,15 +44,15 @@ install() {
         # not readable in qeth interfaces
         # that have just been assembled, ignore
         # read error and assume no carrier
-        read carrier 2> /dev/null < "$1/carrier"
+        read -r carrier 2> /dev/null < "$1/carrier"
         [ "$carrier" -eq 1 ] && return 0
         return 1
     }
 
     for dev in /sys/class/net/*; do
-        has_carrier $dev || continue
-        id=$(ccwid $dev)
-        [ -n "$id" ] && inst_rules_qeth $id
+        has_carrier "$dev" || continue
+        id=$(ccwid "$dev")
+        [ -n "$id" ] && inst_rules_qeth "$id"
     done
 
     inst_simple /usr/lib/udev/collect