From: Oliver Kurth Date: Mon, 9 Sep 2019 18:23:49 +0000 (-0700) Subject: Backout the previous AppInfo OVT Coverity fix. X-Git-Tag: stable-11.1.0~232 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d15cb89dbaf17e6e9f89ed02fc180ebe43a49eb9;p=thirdparty%2Fopen-vm-tools.git Backout the previous AppInfo OVT Coverity fix. --- diff --git a/open-vm-tools/services/plugins/appInfo/appInfo.c b/open-vm-tools/services/plugins/appInfo/appInfo.c index 8801b68a0..774ccae9e 100644 --- a/open-vm-tools/services/plugins/appInfo/appInfo.c +++ b/open-vm-tools/services/plugins/appInfo/appInfo.c @@ -228,14 +228,11 @@ AppInfoGatherTask(ToolsAppCtx *ctx, tstamp = VMTools_GetTimeAsString(); + len = Str_Snprintf(tmpBuf, sizeof tmpBuf, headerFmt, APP_INFO_VERSION_1, counter, tstamp != NULL ? tstamp : ""); - if (len <= 0) { - g_warning("Insufficient space for the header.\n"); - goto abort; - } DynBuf_Append(&dynBuffer, tmpBuf, len);