From: Tobias Brunner <tobias@strongswan.org>
Date: Wed, 29 Jan 2020 10:05:30 +0000 (+0100)
Subject: pki: Remove unnecessary and problematic chunk_from_chars() usage in --signcrl
X-Git-Tag: 5.8.3dr1~33
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d16e81077808c9c898e35db0f4b8f60e0490bf09;p=thirdparty%2Fstrongswan.git

pki: Remove unnecessary and problematic chunk_from_chars() usage in --signcrl

If the serial is not yet set, the same default value is set just below.

See 8ea13bbc5ccd for details on chunk_from_chars().

References #3249.
---

diff --git a/src/pki/commands/signcrl.c b/src/pki/commands/signcrl.c
index dfe1ce014a..60d880eed7 100644
--- a/src/pki/commands/signcrl.c
+++ b/src/pki/commands/signcrl.c
@@ -385,10 +385,6 @@ static int sign_crl()
 	}
 	else
 	{
-		if (!crl_serial.ptr)
-		{
-			crl_serial = chunk_from_chars(0x00);
-		}
 		lastenum = enumerator_create_empty();
 	}