From: James Jones <jejones3141@gmail.com>
Date: Mon, 14 Nov 2022 15:24:24 +0000 (-0600)
Subject: Check return from fr_dict_unknown_attr_afrom_num() (CID #1503891) (#4748)
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d196fb10c073841979c4a05a5da3205344c8604b;p=thirdparty%2Ffreeradius-server.git

Check return from fr_dict_unknown_attr_afrom_num() (CID #1503891) (#4748)
---

diff --git a/src/protocols/internal/decode.c b/src/protocols/internal/decode.c
index d5fde8448fc..3cfe403ea6f 100644
--- a/src/protocols/internal/decode.c
+++ b/src/protocols/internal/decode.c
@@ -253,6 +253,7 @@ static ssize_t internal_decode_pair(TALLOC_CTX *ctx, fr_pair_list_t *out, fr_dic
 	unknown:
 		FR_PROTO_TRACE("Unknown attribute %" PRIu64, type);
 		da = fr_dict_unknown_attr_afrom_num(ctx, parent_da, type);
+		if (!da) return PAIR_DECODE_FATAL_ERROR;
 	} else {
 		da = fr_dict_attr_child_by_num(parent_da, type);
 		if (!da) {