From: Tobias Stoeckmann <tobias@stoeckmann.org>
Date: Fri, 3 Apr 2026 07:38:43 +0000 (+0200)
Subject: login: Clean up PAM resources on error path
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d1a620f96bafc31b946d8d694aa0c5eeb6a2e4f0;p=thirdparty%2Futil-linux.git

login: Clean up PAM resources on error path

If PAM_REINITIALIZEE_CRED fails at this point, PAM_ESTABLISH_CRED
succeeded before. Clean up credentials with PAM_DELETE_CRED in this case
just to be sure.

Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>
---

diff --git a/login-utils/login.c b/login-utils/login.c
index 8459a013a..b6d8aaf2a 100644
--- a/login-utils/login.c
+++ b/login-utils/login.c
@@ -1094,6 +1094,7 @@ static void loginpam_session(struct login_context *cxt)
 
 	rc = pam_setcred(pamh, PAM_REINITIALIZE_CRED);
 	if (is_pam_failure(rc)) {
+		pam_setcred(cxt->pamh, PAM_DELETE_CRED);
 		pam_close_session(pamh, 0);
 		loginpam_err(pamh, rc);
 	}