From: Jeff Lucovsky <jlucovsky@oisf.net>
Date: Tue, 22 Aug 2023 14:17:24 +0000 (-0400)
Subject: stats: Track stream reassembly drops
X-Git-Tag: suricata-6.0.15~8
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d1bd80fce61a9f0a4207713ee3cc9d3f489a8a61;p=thirdparty%2Fsuricata.git

stats: Track stream reassembly drops

Issue: 6235
(cherry picked from commit 904f0ddeeeb1bdb4a686f991cf090a47dd84249e)
---

diff --git a/src/decode.c b/src/decode.c
index 8d0e3feb2e..45301f78d7 100644
--- a/src/decode.c
+++ b/src/decode.c
@@ -794,6 +794,8 @@ const char *PacketDropReasonToString(enum PacketDropReason r)
             return "stream memcap";
         case PKT_DROP_REASON_STREAM_MIDSTREAM:
             return "stream midstream";
+        case PKT_DROP_REASON_STREAM_REASSEMBLY:
+            return "stream reassembly";
         case PKT_DROP_REASON_APPLAYER_ERROR:
             return "applayer error";
         case PKT_DROP_REASON_APPLAYER_MEMCAP:
diff --git a/src/decode.h b/src/decode.h
index 91029fa1f1..a77c7c7f18 100644
--- a/src/decode.h
+++ b/src/decode.h
@@ -411,6 +411,7 @@ enum PacketDropReason {
     PKT_DROP_REASON_STREAM_ERROR,
     PKT_DROP_REASON_STREAM_MEMCAP,
     PKT_DROP_REASON_STREAM_MIDSTREAM,
+    PKT_DROP_REASON_STREAM_REASSEMBLY,
 };
 
 /* forward declaration since Packet struct definition requires this */
diff --git a/src/stream-tcp-reassemble.c b/src/stream-tcp-reassemble.c
index 9ba06f563f..325448bd4e 100644
--- a/src/stream-tcp-reassemble.c
+++ b/src/stream-tcp-reassemble.c
@@ -1903,7 +1903,7 @@ int StreamTcpReassembleHandleSegment(ThreadVars *tv, TcpReassemblyThreadCtx *ra_
             SCLogDebug("StreamTcpReassembleHandleSegmentHandleData error");
             /* failure can only be because of memcap hit, so see if this should lead to a drop */
             ExceptionPolicyApply(
-                    p, stream_config.reassembly_memcap_policy, PKT_DROP_REASON_STREAM_MEMCAP);
+                    p, stream_config.reassembly_memcap_policy, PKT_DROP_REASON_STREAM_REASSEMBLY);
             SCReturnInt(-1);
         }