From: Darren Tucker <dtucker@dtucker.net>
Date: Thu, 18 Jul 2019 00:17:54 +0000 (+1000)
Subject: Allow low-priv tests to write to pipe dir.
X-Git-Tag: V_8_1_P1~151
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d1c491ecb939ee10b341fa7bb6205dff19d297e5;p=thirdparty%2Fopenssh-portable.git

Allow low-priv tests to write to pipe dir.

When running regression tests with Valgrind and SUDO, the low-priv agent
tests need to be able to create pipes in the appropriate directory.
---

diff --git a/regress/test-exec.sh b/regress/test-exec.sh
index 274470761..a0bff3112 100644
--- a/regress/test-exec.sh
+++ b/regress/test-exec.sh
@@ -154,8 +154,10 @@ SCP_BIN=${SCP}
 if [ "x$USE_VALGRIND" != "x" ]; then
 	rm -rf $OBJ/valgrind-out $OBJ/valgrind-vgdb
 	mkdir -p $OBJ/valgrind-out $OBJ/valgrind-vgdb
-	# ensure agent low-priv tests can write logs.
-	chmod 777 $OBJ/valgrind-out
+	# When using sudo ensure low-priv tests can write pipes and logs.
+	if [ "x$SUDO" != "x" ]; then
+		chmod 777 $OBJ/valgrind-out $OBJ/valgrind-vgdb
+	fi
 	VG_TEST=`basename $SCRIPT .sh`
 
 	# Some tests are difficult to fix.