From: David Malcolm <dmalcolm@redhat.com>
Date: Thu, 31 Oct 2024 16:24:55 +0000 (-0400)
Subject: diagnostics: fix memory leak of m_option_mgr
X-Git-Tag: basepoints/gcc-16~4748
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d1d3c17258a564ade216ec908ac99ab6c78f8e3e;p=thirdparty%2Fgcc.git

diagnostics: fix memory leak of m_option_mgr

Fix some noise seen in "make selftest-valgrind".

gcc/ChangeLog:
	* diagnostic.cc (diagnostic_context::finish): Delete and reset
	m_option_mgr.

Signed-off-by: David Malcolm <dmalcolm@redhat.com>
---

diff --git a/gcc/diagnostic.cc b/gcc/diagnostic.cc
index 477214c15f2b..ecc4bd94eba1 100644
--- a/gcc/diagnostic.cc
+++ b/gcc/diagnostic.cc
@@ -420,6 +420,9 @@ diagnostic_context::finish ()
       m_client_data_hooks = nullptr;
     }
 
+  delete m_option_mgr;
+  m_option_mgr = nullptr;
+
   delete m_urlifier;
   m_urlifier = nullptr;