From: Jouni Malinen <j@w1.fi>
Date: Sun, 7 Feb 2016 19:01:41 +0000 (+0200)
Subject: EAP peer: Simplify buildNotify return
X-Git-Tag: hostap_2_6~921
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d1d8a2bd622a199e2f861cef100b6619d983fbec;p=thirdparty%2Fhostap.git

EAP peer: Simplify buildNotify return

There is no need for the local variable and two return statements.

Signed-off-by: Jouni Malinen <j@w1.fi>
---

diff --git a/src/eap_peer/eap.c b/src/eap_peer/eap.c
index 463416917..9110ca5b9 100644
--- a/src/eap_peer/eap.c
+++ b/src/eap_peer/eap.c
@@ -1520,15 +1520,9 @@ static void eap_sm_processNotify(struct eap_sm *sm, const struct wpabuf *req)
 
 static struct wpabuf * eap_sm_buildNotify(int id)
 {
-	struct wpabuf *resp;
-
 	wpa_printf(MSG_DEBUG, "EAP: Generating EAP-Response Notification");
-	resp = eap_msg_alloc(EAP_VENDOR_IETF, EAP_TYPE_NOTIFICATION, 0,
-			     EAP_CODE_RESPONSE, id);
-	if (resp == NULL)
-		return NULL;
-
-	return resp;
+	return eap_msg_alloc(EAP_VENDOR_IETF, EAP_TYPE_NOTIFICATION, 0,
+			EAP_CODE_RESPONSE, id);
 }