From: Rico Tzschichholz <ricotz@ubuntu.com>
Date: Thu, 31 Jan 2019 19:09:07 +0000 (+0100)
Subject: codegen: Pass lambda expression of variable initializer to signal connect
X-Git-Tag: 0.42.6~20
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d1f450e03ae6a8ae8983218bd2d242b61072ff05;p=thirdparty%2Fvala.git

codegen: Pass lambda expression of variable initializer to signal connect
---

diff --git a/codegen/valagsignalmodule.vala b/codegen/valagsignalmodule.vala
index f9a3b9faf..fd1a1129d 100644
--- a/codegen/valagsignalmodule.vala
+++ b/codegen/valagsignalmodule.vala
@@ -606,11 +606,14 @@ public class Vala.GSignalModule : GObjectModule {
 		string connect_func;
 
 		DelegateType? dt = null;
-		var p = handler.symbol_reference as Parameter;
-		if (p != null) {
-			dt = p.variable_type as DelegateType;
+		if (handler.symbol_reference is Variable) {
+			dt = ((Variable) handler.symbol_reference).variable_type as DelegateType;
 			if (dt != null && !context.experimental) {
-				Report.warning (dt.source_reference, "Connecting delegates to signals is experimental");
+				Report.warning (handler.source_reference, "Connecting delegates to signals is experimental");
+			}
+			// Use actual lambda expression if available for proper target/destroy handling
+			if (((Variable) handler.symbol_reference).initializer is LambdaExpression) {
+				handler = ((Variable) handler.symbol_reference).initializer;
 			}
 		}
 		var m = handler.symbol_reference as Method;
diff --git a/tests/Makefile.am b/tests/Makefile.am
index fe5aa20ae..b44a03fe0 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -271,6 +271,7 @@ TESTS = \
 	objects/regex.vala \
 	objects/signals.vala \
 	objects/signals-delegate.vala \
+	objects/signals-lambda-delegate.vala \
 	objects/test-025.vala \
 	objects/test-026.vala \
 	objects/test-029.vala \
diff --git a/tests/objects/signals-lambda-delegate.vala b/tests/objects/signals-lambda-delegate.vala
new file mode 100644
index 000000000..5a8a34368
--- /dev/null
+++ b/tests/objects/signals-lambda-delegate.vala
@@ -0,0 +1,39 @@
+class Foo : Object {
+	public signal void bar (string s);
+	public signal void baz (string s);
+}
+
+delegate void FooFunc (Foo foo, string s);
+
+void main () {
+	var foo = new Foo ();
+	ulong bar_id = 0U;
+	ulong baz_id = 0U;
+	{
+		FooFunc callback = (f,s) => {
+			assert (s == "bar" || s == "baz");
+
+			if (s == "bar") {
+				assert (bar_id > 0U);
+				f.disconnect (bar_id);
+				bar_id = 0U;
+			}
+
+			if (s == "baz") {
+				assert (baz_id > 0U);
+				f.disconnect (baz_id);
+				baz_id = 0U;
+			}
+		};
+
+		bar_id = foo.bar.connect (callback);
+		baz_id = foo.baz.connect (callback);
+	}
+	{
+		foo.bar ("bar");
+		assert (bar_id == 0U);
+
+		foo.baz ("baz");
+		assert (baz_id == 0U);
+	}
+}