From: Michal Privoznik Date: Tue, 29 Nov 2022 15:55:16 +0000 (+0100) Subject: virCommandDoAsyncIO: Drop misleading statement about main event loop X-Git-Tag: v9.0.0-rc1~272 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d1f7fb7a8da8eb7849c96ba62482f293f342b3df;p=thirdparty%2Flibvirt.git virCommandDoAsyncIO: Drop misleading statement about main event loop Back in v1.0.3-rc1~235 when I was adding virCommandDoAsyncIO(), the main event loop was used to poll() on the pipe to the child process. But this was promptly changed to a separate thread handling I/O in v1.0.3-rc1~127. However, the corresponding comment to virCommandDoAsyncIO() still documents the original state. Signed-off-by: Michal Privoznik Reviewed-by: Jonathon Jongsma --- diff --git a/src/util/vircommand.c b/src/util/vircommand.c index cdc74bc2fd..4f60432c0a 100644 --- a/src/util/vircommand.c +++ b/src/util/vircommand.c @@ -3078,8 +3078,6 @@ virCommandFree(virCommand *cmd) * * ... * - * - * The libvirt's event loop is used for handling stdios of @cmd. * Since current implementation uses strlen to determine length * of data to be written to @cmd's stdin, don't pass any binary * data. If you want to re-run command, you need to call this and