From: Vineet Agarwal Date: Tue, 12 May 2026 04:11:57 +0000 (+0530) Subject: mm/damon/sysfs-schemes: fix double increment of nr_regions X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d200cfc81c069e2192c6cc082c38d1c8b0427989;p=thirdparty%2Flinux.git mm/damon/sysfs-schemes: fix double increment of nr_regions damos_sysfs_populate_region_dir() increments sysfs_regions->nr_regions twice when adding a new region: once explicitly before kobject_init_and_add(), and once again through the post-increment used for the kobject name. As a result, nr_regions no longer matches the actual number of live regions, and region directory names skip numbers (1, 3, 5, ...). Use the already incremented value for naming instead of incrementing nr_regions a second time. Link: https://lore.kernel.org/20260512041157.109845-1-agarwal.vineet2006@gmail.com Fixes: 66178e4ec30a ("mm/damon/sysfs: use damos_walk() for update_schemes_tried_{bytes,regions}") Signed-off-by: Vineet Agarwal Reviewed-by: SeongJae Park Signed-off-by: Andrew Morton --- diff --git a/mm/damon/sysfs-schemes.c b/mm/damon/sysfs-schemes.c index ab2153fff9a8..0d3021db0b99 100644 --- a/mm/damon/sysfs-schemes.c +++ b/mm/damon/sysfs-schemes.c @@ -2995,7 +2995,7 @@ void damos_sysfs_populate_region_dir(struct damon_sysfs_schemes *sysfs_schemes, if (kobject_init_and_add(®ion->kobj, &damon_sysfs_scheme_region_ktype, &sysfs_regions->kobj, "%d", - sysfs_regions->nr_regions++)) { + sysfs_regions->nr_regions)) { kobject_put(®ion->kobj); return; }