From: Peter Krempa <pkrempa@redhat.com>
Date: Tue, 29 May 2018 18:06:35 +0000 (+0200)
Subject: qemu: hotplug: Don't mandate passing of 'secAlias' in qemuDomainGetTLSObjects
X-Git-Tag: v4.5.0-rc1~324
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d23fd6183662e3adc4a5abb293d4bd2aad61e882;p=thirdparty%2Flibvirt.git

qemu: hotplug: Don't mandate passing of 'secAlias' in qemuDomainGetTLSObjects

For some reason the function returned an error if secAlias was not
passed in. It's not an error, in fact it's desired.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 98f8df6959..713f88fcf5 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu/qemu_hotplug.c
@@ -1513,7 +1513,7 @@ qemuDomainGetTLSObjects(virQEMUCapsPtr qemuCaps,
         if (qemuBuildSecretInfoProps(secinfo, secProps) < 0)
             return -1;
 
-        if (!secAlias ||
+        if (secAlias &&
             !(*secAlias = qemuDomainGetSecretAESAlias(srcAlias, false)))
             return -1;
     }