From: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Date: Mon, 10 Aug 2020 11:36:15 +0000 (+0200)
Subject: Add comment what the effect of calling the qname-minimization
X-Git-Tag: rec-4.3.4^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d274b481cb6cf66fd1e9acd754535261a4b1ea83;p=thirdparty%2Fpdns.git

Add comment what the effect of calling the qname-minimization
fallback code can be for maxdepth.

(cherry picked from commit a4980f5632404f84b7de976595d43b4969b7feac)
---

diff --git a/pdns/syncres.cc b/pdns/syncres.cc
index 97a813ece7..24b0a8f505 100644
--- a/pdns/syncres.cc
+++ b/pdns/syncres.cc
@@ -739,6 +739,9 @@ int SyncRes::doResolve(const DNSName &qname, const QType &qtype, vector<DNSRecor
         // Case 5: unexpected answer
         QLOG("Step5: other rcode, last effort final resolve");
         setQNameMinimization(false);
+        // We might have hit a depth level check, but we still want to allow some recursion levels in the fallback
+        // no-qname-minimization case. This has the effect that a qname minimization fallback case might reach 150% of
+        // maxdepth.
         res = doResolveNoQNameMinimization(qname, qtype, ret, depth/2, beenthere, state);
 
         if(res == RCode::NoError) {