From: justdave%syndicomm.com <>
Date: Sat, 15 Nov 2003 15:38:59 +0000 (+0000)
Subject: Bug 225474: Fixing regression from bug 217422, xml.cgi got busted, and the patch... 
X-Git-Tag: bugzilla-2.16.5~17
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d2792793d071297e9c5cfb98fd9847e7bcc1b262;p=thirdparty%2Fbugzilla.git

Bug 225474: Fixing regression from bug 217422, xml.cgi got busted, and the patch from bug 217422 (MySQL 4 compatibility for show_bug) didn't accomplish what it was supposed to anyway.  This checkin fixes both.
r= bbaetz, a= justdave
---

diff --git a/Bug.pm b/Bug.pm
index 05d25a97fb..ee4f2164f5 100755
--- a/Bug.pm
+++ b/Bug.pm
@@ -112,7 +112,7 @@ sub initBug  {
       resolution, priority, bug_severity, component, assigned_to, reporter,
       bug_file_loc, short_desc, target_milestone, qa_contact,
       status_whiteboard, date_format(creation_ts,'%Y-%m-%d %H:%i'),
-      groupset, delta_ts, ifnull(sum(votes.vote_count),0),
+      groupset, delta_ts, ifnull(sum(votes.count),0)
     from bugs left join votes using(bug_id)
     where bugs.bug_id = $bug_id
     group by bugs.bug_id";
diff --git a/bug_form.pl b/bug_form.pl
index 14e9147bac..68f4c9f3d1 100644
--- a/bug_form.pl
+++ b/bug_form.pl
@@ -83,7 +83,7 @@ sub show_bug {
         bug_file_loc, short_desc, target_milestone, 
         qa_contact, status_whiteboard, 
         date_format(creation_ts,'%Y-%m-%d %H:%i'),
-        groupset, delta_ts, sum(votes.count)
+        groupset, delta_ts, ifnull(sum(votes.count),0)
     FROM bugs LEFT JOIN votes USING(bug_id)
     WHERE bugs.bug_id = $id
     GROUP BY bugs.bug_id";