From: Alan T. DeKok <aland@freeradius.org>
Date: Tue, 26 Oct 2021 12:32:56 +0000 (-0400)
Subject: UINT8_MAX is 255.  Characters go from 0..255.  Which is 256
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d28cb90357461f8ba7888e679961da3d67ae8cee;p=thirdparty%2Ffreeradius-server.git

UINT8_MAX is 255.  Characters go from 0..255.  Which is 256
---

diff --git a/src/lib/util/base16.c b/src/lib/util/base16.c
index 441e31b8bbf..98793ff4bc1 100644
--- a/src/lib/util/base16.c
+++ b/src/lib/util/base16.c
@@ -28,7 +28,7 @@ RCSID("$Id$")
 /** lower case encode alphabet for base16
  *
  */
-char const fr_base16_alphabet_encode_lc[UINT8_MAX] = {
+char const fr_base16_alphabet_encode_lc[UINT8_MAX + 1] = {
 	[0] = '0',
 	[1] = '1',
 	[2] = '2',
@@ -50,7 +50,7 @@ char const fr_base16_alphabet_encode_lc[UINT8_MAX] = {
 /** lower case encode alphabet for base16
  *
  */
-char const fr_base16_alphabet_encode_uc[UINT8_MAX] = {
+char const fr_base16_alphabet_encode_uc[UINT8_MAX + 1] = {
 	[0] = '0',
 	[1] = '1',
 	[2] = '2',
@@ -72,7 +72,7 @@ char const fr_base16_alphabet_encode_uc[UINT8_MAX] = {
 /** Mixed case decode alphabet for base16
  *
  */
-uint8_t const fr_base16_alphabet_decode_mc[UINT8_MAX] = {
+uint8_t const fr_base16_alphabet_decode_mc[UINT8_MAX + 1] = {
 	F32(0, UINT8_MAX), F16(32, UINT8_MAX),
 	['0'] = 0,
 	['1'] = 1,
diff --git a/src/lib/util/base16.h b/src/lib/util/base16.h
index 7962ad2e09c..3623ccb4832 100644
--- a/src/lib/util/base16.h
+++ b/src/lib/util/base16.h
@@ -36,9 +36,9 @@ extern "C" {
 #include <stdint.h>
 #include <sys/types.h>
 
-extern char const fr_base16_alphabet_encode_lc[UINT8_MAX];
-extern char const fr_base16_alphabet_encode_uc[UINT8_MAX];
-extern uint8_t const fr_base16_alphabet_decode_mc[UINT8_MAX];	/* mixed case */
+extern char const fr_base16_alphabet_encode_lc[UINT8_MAX + 1];
+extern char const fr_base16_alphabet_encode_uc[UINT8_MAX + 1];
+extern uint8_t const fr_base16_alphabet_decode_mc[UINT8_MAX + 1];	/* mixed case */
 
 /** Check if char is in base16 alphabet
  *