From: Alan T. DeKok <aland@freeradius.org>
Date: Thu, 19 Oct 2017 19:52:11 +0000 (-0400)
Subject: close socket on error.  CID #1419878
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d299ef7889db2cb1efa4fd98a1e9cd7e8d48987b;p=thirdparty%2Ffreeradius-server.git

close socket on error.  CID #1419878
---

diff --git a/src/lib/util/socket.c b/src/lib/util/socket.c
index f98efc56c78..9473bca40b8 100644
--- a/src/lib/util/socket.c
+++ b/src/lib/util/socket.c
@@ -443,7 +443,10 @@ int fr_socket_client_udp(fr_ipaddr_t *src_ipaddr, uint16_t *src_port, fr_ipaddr_
 		if (!src_ipaddr) src_ipaddr = &my_ipaddr;
 		if (!src_port) src_port = &my_port;
 
-		if (fr_ipaddr_from_sockaddr(&salocal, salen, src_ipaddr, src_port) < 0) return -1;
+		if (fr_ipaddr_from_sockaddr(&salocal, salen, src_ipaddr, src_port) < 0) {
+			close(sockfd);
+			return -1;
+		}
 	}
 
 	/*