From: Tim Wiederhake <twiederh@redhat.com>
Date: Mon, 5 Jul 2021 14:58:22 +0000 (+0200)
Subject: virFileCacheNew: `virHashNew` cannot return NULL
X-Git-Tag: v7.6.0-rc1~44
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d2a57b4d68f0ce030f085e26ce74b2d2a20f1849;p=thirdparty%2Flibvirt.git

virFileCacheNew: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
---

diff --git a/src/util/virfilecache.c b/src/util/virfilecache.c
index 2f55deefb6..64348dc1e6 100644
--- a/src/util/virfilecache.c
+++ b/src/util/virfilecache.c
@@ -242,8 +242,7 @@ virFileCacheNew(const char *dir,
     if (!(cache = virObjectNew(virFileCacheClass)))
         return NULL;
 
-    if (!(cache->table = virHashNew(virObjectFreeHashData)))
-        goto cleanup;
+    cache->table = virHashNew(virObjectFreeHashData);
 
     cache->dir = g_strdup(dir);
 
@@ -252,10 +251,6 @@ virFileCacheNew(const char *dir,
     cache->handlers = *handlers;
 
     return cache;
-
- cleanup:
-    virObjectUnref(cache);
-    return NULL;
 }