From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Wed, 29 Jul 2015 23:21:03 +0000 (-0400)
Subject: Fifo code should use unsigned ints
X-Git-Tag: release_3_0_10~277
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d2ad9e4f0d086d9618a7d11ad63bb8483e211dd4;p=thirdparty%2Ffreeradius-server.git

Fifo code should use unsigned ints
---

diff --git a/src/include/libradius.h b/src/include/libradius.h
index a6d20f782fc..891df0d902a 100644
--- a/src/include/libradius.h
+++ b/src/include/libradius.h
@@ -909,7 +909,7 @@ void		fr_fifo_free(fr_fifo_t *fi);
 int		fr_fifo_push(fr_fifo_t *fi, void *data);
 void		*fr_fifo_pop(fr_fifo_t *fi);
 void		*fr_fifo_peek(fr_fifo_t *fi);
-int		fr_fifo_num_elements(fr_fifo_t *fi);
+unsigned int	fr_fifo_num_elements(fr_fifo_t *fi);
 
 /*
  *	socket.c
diff --git a/src/lib/fifo.c b/src/lib/fifo.c
index 8c7e0b62458..7a9ecfac6d8 100644
--- a/src/lib/fifo.c
+++ b/src/lib/fifo.c
@@ -27,9 +27,9 @@ RCSID("$Id$")
 #include <freeradius-devel/libradius.h>
 
 struct fr_fifo_t {
-	int num;
-	int first, last;
-	int max;
+	unsigned int num;
+	unsigned int first, last;
+	unsigned int max;
 	fr_fifo_free_t freeNode;
 
 	void *data[1];
@@ -54,13 +54,13 @@ fr_fifo_t *fr_fifo_create(TALLOC_CTX *ctx, int max, fr_fifo_free_t freeNode)
 
 void fr_fifo_free(fr_fifo_t *fi)
 {
-	int i;
+	unsigned int i;
 
 	if (!fi) return;
 
 	if (fi->freeNode) {
 		for (i = 0 ; i < fi->num; i++) {
-			int element;
+			unsigned int element;
 
 			element = i + fi->first;
 			if (element > fi->max) {
@@ -112,7 +112,7 @@ void *fr_fifo_peek(fr_fifo_t *fi)
 	return fi->data[fi->first];
 }
 
-int fr_fifo_num_elements(fr_fifo_t *fi)
+unsigned int fr_fifo_num_elements(fr_fifo_t *fi)
 {
 	if (!fi) return 0;