From: Adrian Bunk <bunk@stusta.de>
Date: Mon, 28 Nov 2005 11:44:47 +0000 (+0100)
Subject: [PATCH] drivers/message/i2o/pci.c: fix a use-after-free
X-Git-Tag: v2.6.14.4~23
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d2b0e84d195a341c1cc5b45ec2098ee23bc1fe9d;p=thirdparty%2Fkernel%2Fstable.git

[PATCH] drivers/message/i2o/pci.c: fix a use-after-free

The Coverity checker spotted this obvious use-after-free

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Markus Lidel <Markus.Lidel@shadowconnect.com>
Signed-off-by: Chris Wright <chrisw@osdl.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

diff --git a/drivers/message/i2o/pci.c b/drivers/message/i2o/pci.c
index 66c03e8825703..81ef306cb1247 100644
--- a/drivers/message/i2o/pci.c
+++ b/drivers/message/i2o/pci.c
@@ -421,8 +421,8 @@ static int __devinit i2o_pci_probe(struct pci_dev *pdev,
 	i2o_pci_free(c);
 
       free_controller:
-	i2o_iop_free(c);
 	put_device(c->device.parent);
+	i2o_iop_free(c);
 
       disable:
 	pci_disable_device(pdev);