From: Mark Otto <markdotto@gmail.com>
Date: Tue, 6 Jun 2017 06:00:14 +0000 (-0700)
Subject: flesh out invalid styles on .was-validated
X-Git-Tag: v4.0.0-beta~147^2~22
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d2c9f3f00a385a6509589a3b102d1f8ecda84631;p=thirdparty%2Fbootstrap.git

flesh out invalid styles on .was-validated
---

diff --git a/docs/4.0/components/forms.md b/docs/4.0/components/forms.md
index 3fc7bfddcd..b669219556 100644
--- a/docs/4.0/components/forms.md
+++ b/docs/4.0/components/forms.md
@@ -817,11 +817,142 @@ Provide valuable, actionable feedback to your users with HTML5 form validation
 
 Here's a rundown of how form validation works:
 
-- HTML form validation includes support for two CSS pseudo-classes, `:invalid` and `:valid`, for use on `<input>`s.
+- HTML form validation includes support for two CSS pseudo-classes, `:invalid` and `:valid`, on `<input>`, `<select>`, and `<textarea>` elements.
+- Due to constaints in how CSS works, we cannot (at present) apply styles to a `<label>` that comes before a form control in the DOM without the help of custom JavaScript.
+- Bootstrap scopes the `:invalid` and `:valid` styles to parent `.was-validated` class, usually applied to the `<form>`. Otherwise, any required field without a value shows up as invalid on page load. This way, you may choose when to activate them (typically after form submission is attempted).
 - All modern browsers support the [constraint validation API](https://www.w3.org/TR/html5/forms.html#the-constraint-validation-api), a series of JavaScript methods for validating form controls.
-- You may choose to rely on the browser default validation feedback, or implement custom feedback styles with HTML and CSS.
+- Feedback messages may utilize the browser defaults (different for each browser, and unstylable via CSS) or our custom feedback styles with additional HTML and CSS.
 - You may provide custom validity messages with `setCustomValidity` in JavaScript.
 
+With that in mind, consider the following two demos for our custom form validation styles and browser defaults.
+
+### Custom styles
+
+For custom Bootstrap form validation messages, you'll need to add the `novalidate` boolean attribute to your `<form>`. This disables the browser default feedback tooltips, but still provides access to the form validation APIs in JavaScript.
+
+{% example html %}
+<form class="container" id="needs-validation" novalidate>
+  <div class="row">
+    <div class="col-md-6 mb-3">
+      <label for="validationCustom01">First name</label>
+      <input type="text" class="form-control" id="validationCustom01" placeholder="First name" value="Mark" required>
+    </div>
+    <div class="col-md-6 mb-3">
+      <label for="validationCustom02">Last name</label>
+      <input type="text" class="form-control" id="validationCustom02" placeholder="Last name" value="Otto" required>
+    </div>
+  </div>
+  <div class="row">
+    <div class="col-md-6 mb-3">
+      <label for="validationCustom03">City</label>
+      <input type="text" class="form-control" id="validationCustom03" placeholder="City" required>
+      <div class="invalid-feedback">
+        Please provide a valid city.
+      </div>
+    </div>
+    <div class="col-md-3 mb-3">
+      <label for="validationCustom04">State</label>
+      <input type="text" class="form-control" id="validationCustom04" placeholder="State" required>
+      <div class="invalid-feedback">
+        Please provide a valid state.
+      </div>
+    </div>
+    <div class="col-md-3 mb-3">
+      <label for="validationCustom05">Zip</label>
+      <input type="text" class="form-control" id="validationCustom05" placeholder="Zip" required>
+      <div class="invalid-feedback">
+        Please provide a valid zip.
+      </div>
+    </div>
+  </div>
+  <button class="btn btn-primary" type="submit">Submit form</button>
+</form>
+
+<script>
+// Example JavaScript for disabling form submission if there are invalid fields
+(function() {
+  "use strict";
+  window.addEventListener("load", function() {
+    var form = document.getElementById("needs-validation");
+    form.addEventListener("submit", function(event) {
+      if (form.checkValidity() == false) {
+        event.preventDefault();
+        event.stopPropagation();
+      }
+      form.classList.add("was-validated");
+    }, false);
+  }, false);
+}());
+</script>
+{% endexample %}
+
+### Browser defaults
+
+{% example html %}
+<form>
+  <div class="row">
+    <div class="col-md-6 mb-3">
+      <input type="text" class="form-control" placeholder="First name" value="Mark" required>
+    </div>
+    <div class="col-md-6 mb-3">
+      <input type="text" class="form-control" placeholder="Last name" value="Otto" required>
+    </div>
+  </div>
+
+  <div class="row">
+    <div class="col-md-7 mb-3">
+      <input type="text" class="form-control" placeholder="City" required>
+    </div>
+    <div class="col-md-3 mb-3">
+      <input type="text" class="form-control" placeholder="State" required>
+    </div>
+    <div class="col-md-2 mb-3">
+      <input type="text" class="form-control" placeholder="Zip" required>
+    </div>
+  </div>
+
+  <button class="btn btn-primary" type="submit">Submit form</button>
+</form>
+{% endexample %}
+
+### Supported elements
+
+Our example forms show native textual `<input>`s above, but form validation styles are available for our custom form controls, too.
+
+{% example html %}
+<form class="was-validated">
+  <label class="custom-control custom-checkbox">
+    <input type="checkbox" class="custom-control-input" required>
+    <span class="custom-control-indicator"></span>
+    <span class="custom-control-description">Check this custom checkbox</span>
+  </label>
+
+  <div class="custom-controls-stacked d-block my-3">
+    <label class="custom-control custom-radio">
+      <input id="radioStacked1" name="radio-stacked" type="radio" class="custom-control-input" required>
+      <span class="custom-control-indicator"></span>
+      <span class="custom-control-description">Toggle this custom radio</span>
+    </label>
+    <label class="custom-control custom-radio">
+      <input id="radioStacked2" name="radio-stacked" type="radio" class="custom-control-input" required>
+      <span class="custom-control-indicator"></span>
+      <span class="custom-control-description">Or toggle this other custom radio</span>
+    </label>
+  </div>
+
+  <select class="custom-select d-block my-3" required>
+    <option value="">Open this select menu</option>
+    <option value="1">One</option>
+    <option value="2">Two</option>
+    <option value="3">Three</option>
+  </select>
+
+  <label class="custom-file">
+    <input type="file" id="file" class="custom-file-input" required>
+    <span class="custom-file-control"></span>
+  </label>
+</form>
+{% endexample %}
 
 - To use, add `.has-warning`, `.has-danger`, or `.has-success` to the parent element. Any `.col-form-label`, `.form-control`, or custom form element will receive the validation styles.
 - Contextual validation text, in addition to your usual form field help text, can be added with the use of `.form-control-feedback`. This text will adapt to the parent `.has-*` class. By default it only includes a bit of `margin` for spacing and a modified `color` for each state.
diff --git a/scss/_forms.scss b/scss/_forms.scss
index 391a6cb4ff..c49fc39de1 100644
--- a/scss/_forms.scss
+++ b/scss/_forms.scss
@@ -242,6 +242,88 @@ select.form-control-lg {
 //
 // Apply contextual and semantic states to individual form controls.
 
+$form-feedback-valid-color: $green !default;
+$form-feedback-invalid-color: $red !default;
+
+.invalid-feedback {
+  display: none;
+  margin-top: .25rem;
+  font-size: .875rem;
+  color: $form-feedback-invalid-color;
+}
+
+.invalid-tooltip {
+  position: absolute;
+  top: 100%;
+  z-index: 5;
+  display: none;
+  width: 250px;
+  padding: .5rem;
+  margin-top: .1rem;
+  font-size: .875rem;
+  line-height: 1;
+  color: #fff;
+  background-color: rgba($form-feedback-invalid-color,.8);
+  border-radius: .2rem;
+}
+
+.was-validated {
+  // input, textarea, select, and custom select
+  .form-control:invalid,
+  .custom-select:invalid {
+    border-color: $form-feedback-invalid-color;
+
+    &:focus {
+      box-shadow: 0 0 0 .2rem rgba($form-feedback-invalid-color,.25);
+    }
+
+    ~ .invalid-feedback,
+    ~ .invalid-tooltip {
+      display: block;
+    }
+  }
+
+  // TODO: redo check markup lol crap
+  .form-check-input:invalid {
+    + .form-check-label {
+      color: $form-feedback-invalid-color;
+    }
+  }
+
+  // custom radios and checks
+  .custom-control-input:invalid {
+    ~ .custom-control-indicator {
+      background-color: rgba($form-feedback-invalid-color, .25);
+    }
+    ~ .custom-control-description {
+      color: $form-feedback-invalid-color;
+    }
+  }
+
+  // custom file
+  .custom-file-input:invalid {
+    ~ .custom-file-control {
+      border-color: $form-feedback-invalid-color;
+
+      &::before { border-color: inherit; }
+    }
+
+    &:focus {
+      box-shadow: 0 0 0 .2rem rgba($form-feedback-invalid-color,.25);
+    }
+  }
+}
+
+// .is-validated .form-control:invalid {
+//   border-color: rgba(255,0,0,1);
+// }
+// .is-validated .form-control:invalid:focus {
+//   box-shadow: 0 0 0 .2rem rgba(255,0,0,.2);
+// }
+// .is-validated .form-control:invalid + .form-control-invalid-text {
+//   display: block;
+// }
+
 .form-control-feedback {
   margin-top: $form-feedback-margin-top;
 }