From: Christopher Faulet <cfaulet@haproxy.com>
Date: Mon, 8 Jul 2024 17:12:50 +0000 (+0200)
Subject: MINOR: backend: Remove test on HTX streams to reuse idle connections on connect
X-Git-Tag: v3.1-dev4~72
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d2ce835fb793cbc8dc4425ef67ff781ceb230084;p=thirdparty%2Fhaproxy.git

MINOR: backend: Remove test on HTX streams to reuse idle connections on connect

In connect_server() function, there is a test to be able to reuse idle
connections for HTX streams only. Till now, only HTTP connections can be
idle. And this tests was added to be sure to now reuse idle connections for
legacy HTTP streams. But the legacy HTTP was removed in HAProxy-2.1. So we
can safely remove this test.

The related issue is #2502.
---

diff --git a/src/backend.c b/src/backend.c
index d74ae40825..99549fc131 100644
--- a/src/backend.c
+++ b/src/backend.c
@@ -1377,12 +1377,6 @@ int connect_server(struct stream *s)
 		                                srv->pool_conn_name_expr, SMP_T_STR);
 	}
 
-	/* do not reuse if mode is not http */
-	if (!IS_HTX_STRM(s)) {
-		DBG_TRACE_STATE("skip idle connections reuse: no htx", STRM_EV_STRM_PROC|STRM_EV_CS_ST, s);
-		goto skip_reuse;
-	}
-
 	/* disable reuse if websocket stream and the protocol to use is not the
 	 * same as the main protocol of the server.
 	 */