From: Fred Morcos <fred.morcos@open-xchange.com>
Date: Mon, 25 Apr 2022 09:07:27 +0000 (+0200)
Subject: Lint fixes (consts, boolean conditions)
X-Git-Tag: auth-4.8.0-alpha0~117^2~6
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d2e1a4e0b394b62b40f65ae2d089ac5c8aaf44ba;p=thirdparty%2Fpdns.git

Lint fixes (consts, boolean conditions)
---

diff --git a/pdns/decafsigners.cc b/pdns/decafsigners.cc
index 9f3bd1bda3..9ebc9d2aea 100644
--- a/pdns/decafsigners.cc
+++ b/pdns/decafsigners.cc
@@ -421,7 +421,7 @@ bool DecafED448DNSCryptoKeyEngine::verify(const std::string& msg, const std::str
 
 namespace
 {
-struct LoaderDecafStruct
+const struct LoaderDecafStruct
 {
   LoaderDecafStruct()
   {
diff --git a/pdns/dnssecinfra.cc b/pdns/dnssecinfra.cc
index 80a8b89cab..43d623f93e 100644
--- a/pdns/dnssecinfra.cc
+++ b/pdns/dnssecinfra.cc
@@ -225,7 +225,7 @@ vector<pair<uint8_t, string>> DNSCryptoKeyEngine::listAllAlgosWithBackend()
 void DNSCryptoKeyEngine::report(unsigned int algo, maker_t* maker, bool fallback)
 {
   getAllMakers()[algo].push_back(maker);
-  if (getMakers().count(algo) && fallback) {
+  if (getMakers().count(algo) != 0 && fallback) {
     return;
   }
   getMakers()[algo] = maker;
diff --git a/pdns/opensslsigners.cc b/pdns/opensslsigners.cc
index c521e1558f..3b31fa91c9 100644
--- a/pdns/opensslsigners.cc
+++ b/pdns/opensslsigners.cc
@@ -1174,7 +1174,7 @@ void OpenSSLEDDSADNSCryptoKeyEngine::fromPublicKeyString(const std::string& cont
 #endif // HAVE_LIBCRYPTO_EDDSA
 
 namespace {
-  struct LoaderStruct
+  const struct LoaderStruct
   {
     LoaderStruct()
     {
diff --git a/pdns/sodiumsigners.cc b/pdns/sodiumsigners.cc
index dbec4af75e..a918260e41 100644
--- a/pdns/sodiumsigners.cc
+++ b/pdns/sodiumsigners.cc
@@ -200,7 +200,7 @@ bool SodiumED25519DNSCryptoKeyEngine::verify(const std::string& msg, const std::
 }
 
 namespace {
-struct LoaderSodiumStruct
+const struct LoaderSodiumStruct
 {
   LoaderSodiumStruct()
   {