From: Martin Schwenke Date: Sun, 16 Nov 2025 23:20:11 +0000 (+1100) Subject: ctdb-common: Align integer type X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d2f93469d50916d355d718d48e83768af6997052;p=thirdparty%2Fsamba.git ctdb-common: Align integer type [132/416] Compiling ctdb/common/run_event.c ../../common/run_event.c: In function ‘run_event_fail’: ../../common/run_event.c:806:50: warning: comparison of integer expressions of different signedness: ‘id_t’ {aka ‘unsigned int’} and ‘int’ [-Wsign-compare] 806 | if (script->summary == -ETIMEDOUT && pid != -1) { | ^~ This is actually due to a typo in commit 20e9f203627752c4c1934e4bc0776e26c0dfb00e. It should always have been pid_t. Signed-off-by: Martin Schwenke Reviewed-by: Volker Lendecke --- diff --git a/ctdb/common/run_event.c b/ctdb/common/run_event.c index dee46ad2949..4434fc18804 100644 --- a/ctdb/common/run_event.c +++ b/ctdb/common/run_event.c @@ -548,7 +548,7 @@ static struct tevent_req *run_event_run_script(struct tevent_req *req); static void run_event_next_script(struct tevent_req *subreq); static void run_event_fail(struct tevent_req *req, struct run_event_script *script, - id_t pid); + pid_t pid); static void run_event_debug(struct tevent_req *req, pid_t pid); static void run_event_debug_done(struct tevent_req *subreq); @@ -791,7 +791,7 @@ static void run_event_next_script(struct tevent_req *subreq) static void run_event_fail(struct tevent_req *req, struct run_event_script *script, - id_t pid) + pid_t pid) { struct run_event_state *state = tevent_req_data( req, struct run_event_state);