From: Douglas Bagnall Date: Thu, 6 Nov 2025 03:08:30 +0000 (+1300) Subject: s4:torture:kdc-canon: test each combination only once X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d3034ae3e2833cb5d5a7dc500df4adf83ff52263;p=thirdparty%2Fsamba.git s4:torture:kdc-canon: test each combination only once These tests exhaustively combinations of binary options. With 492d9f083dc23aff2c1fa12e21765861df1c1b38 ("s4:torture: Remove netbios realm and lowercase realm tests") we removed some test flags, reducing the number of flags to 8, so there are 256 combinations. But we test every bit combination of TEST_ALL which was 10 bits (0x3ff), and each test was run 4 times ignoring the 0x4 and 0x10 bits. So we compact the flags into 8 bits and run each one once. Signed-off-by: Douglas Bagnall Reviewed-by: Jennifer Sutton --- diff --git a/source4/torture/krb5/kdc-canon-heimdal.c b/source4/torture/krb5/kdc-canon-heimdal.c index 392329a66e2..a64c73d809e 100644 --- a/source4/torture/krb5/kdc-canon-heimdal.c +++ b/source4/torture/krb5/kdc-canon-heimdal.c @@ -38,13 +38,13 @@ #define TEST_CANONICALIZE 0x0000001 #define TEST_ENTERPRISE 0x0000002 -#define TEST_UPPER_USERNAME 0x0000008 -#define TEST_WIN2K 0x0000020 -#define TEST_UPN 0x0000040 -#define TEST_S4U2SELF 0x0000080 -#define TEST_REMOVEDOLLAR 0x0000100 -#define TEST_AS_REQ_SPN 0x0000200 -#define TEST_ALL 0x00003FF +#define TEST_UPPER_USERNAME 0x0000004 +#define TEST_WIN2K 0x0000008 +#define TEST_UPN 0x0000010 +#define TEST_S4U2SELF 0x0000020 +#define TEST_REMOVEDOLLAR 0x0000040 +#define TEST_AS_REQ_SPN 0x0000080 +#define TEST_ALL 0x00000FF struct test_data { const char *test_name;