From: Richard Levitte <levitte@openssl.org>
Date: Fri, 20 Jun 2025 12:29:04 +0000 (+0200)
Subject: Nit: macro parameters should always be parenthesised in expressions
X-Git-Tag: openssl-3.4.2~9
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d334c8053efd9ffd1f044e096ff4eb452bd65c5d;p=thirdparty%2Fopenssl.git

Nit: macro parameters should always be parenthesised in expressions

Affected macros: ossl_likely and ossl_unlikely

Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Neil Horman <nhorman@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/27862)

(cherry picked from commit cdd01b5e0734b0324251b32a8edd97f42ba90429)
---

diff --git a/include/internal/common.h b/include/internal/common.h
index 0c0415b777b..af6d7db6c25 100644
--- a/include/internal/common.h
+++ b/include/internal/common.h
@@ -22,8 +22,8 @@
 #  define ossl_likely(x)     __builtin_expect(!!(x), 1)
 #  define ossl_unlikely(x)   __builtin_expect(!!(x), 0)
 # else
-#  define ossl_likely(x)     x
-#  define ossl_unlikely(x)   x
+#  define ossl_likely(x)     (x)
+#  define ossl_unlikely(x)   (x)
 # endif
 
 # if defined(__GNUC__) || defined(__clang__)