From: Ján Tomko <jtomko@redhat.com>
Date: Sun, 2 Aug 2020 12:58:38 +0000 (+0200)
Subject: virt-login-shell: correctly calculate string length
X-Git-Tag: v6.7.0-rc1~220
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d339113ab050107fcc4e2a3e9ab939cd92352efe;p=thirdparty%2Flibvirt.git

virt-login-shell: correctly calculate string length

virLoginShellGetShellArgv was not dereferencing the pointer
to the string list containing the shell parameters from the
config file, thus setting some random number as shargvlen.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Fixes: 740e4d705284ba0598258291c2656f50075486f0
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
---

diff --git a/tools/virt-login-shell-helper.c b/tools/virt-login-shell-helper.c
index d9db883ee6..2db349754e 100644
--- a/tools/virt-login-shell-helper.c
+++ b/tools/virt-login-shell-helper.c
@@ -104,7 +104,7 @@ static int virLoginShellGetShellArgv(virConfPtr conf,
         (*shargv)[0] = g_strdup("/bin/sh");
         *shargvlen = 1;
     } else {
-        *shargvlen = virStringListLength((const char *const *)shargv);
+        *shargvlen = virStringListLength((const char *const *)*shargv);
     }
     return 0;
 }