From: Axel Viala Date: Fri, 23 Sep 2022 10:13:40 +0000 (+0200) Subject: NIT: move len near usage. X-Git-Tag: dnsdist-1.8.0-rc1~220^2~2 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d3511c5e2b0ff1935262c3b02952b24931d800bc;p=thirdparty%2Fpdns.git NIT: move len near usage. --- diff --git a/pdns/dynlistener.cc b/pdns/dynlistener.cc index 70a9270a61..5973d73921 100644 --- a/pdns/dynlistener.cc +++ b/pdns/dynlistener.cc @@ -214,8 +214,6 @@ string DynListener::getLine() vector mesg; mesg.resize(1024000); - ssize_t len = 0; - ComboAddress remote; socklen_t remlen=remote.getSocklen(); @@ -273,7 +271,9 @@ string DynListener::getLine() if(isatty(0) != 0) if(write(1, "% ", 2) !=2) throw PDNSException("Writing to console: "+stringerror()); - if((len=read(0, mesg.data(), mesg.size())) < 0) + + ssize_t len = read(0, mesg.data(), mesg.size()); + if (len < 0) throw PDNSException("Reading from the control pipe: "+stringerror()); else if(len==0) throw PDNSException("Guardian exited - going down as well");