From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Tue, 5 Mar 2019 11:30:32 +0000 (+0800)
Subject: Fix return codes
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d35eea8bb99dd6768bdec0720c3fa368252a0170;p=thirdparty%2Ffreeradius-server.git

Fix return codes
---

diff --git a/src/lib/server/module.c b/src/lib/server/module.c
index 20fd69b25d7..18237bc55fb 100644
--- a/src/lib/server/module.c
+++ b/src/lib/server/module.c
@@ -307,7 +307,7 @@ fr_pool_t *module_connection_pool_init(CONF_SECTION *module,
 
 		if (fr_pool_start(pool) < 0) {
 			ERROR("%s: Starting initial connections failed", log_prefix);
-			return -1;
+			return NULL;
 		}
 
 		DEBUG4("%s: Adding pool reference %p to config item \"%s.pool\"", log_prefix, pool, parent_name(cs));
diff --git a/src/lib/server/pool.c b/src/lib/server/pool.c
index afa177a362b..cad160ab73f 100644
--- a/src/lib/server/pool.c
+++ b/src/lib/server/pool.c
@@ -1024,7 +1024,7 @@ fr_pool_t *fr_pool_init(TALLOC_CTX *ctx,
 		ERROR("%s: Failed creating connection heap", __FUNCTION__);
 	error:
 		fr_pool_free(pool);
-		return -1;
+		return NULL;
 	}
 
 	pool->log_prefix = log_prefix ? talloc_typed_strdup(pool, log_prefix) : "core";