From: Alan T. DeKok <aland@freeradius.org>
Date: Mon, 21 Jul 2025 07:40:03 +0000 (+0200)
Subject: don't append output book on failure
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d361dfd3b2b54f917de17e7d666be1c2467bc802;p=thirdparty%2Ffreeradius-server.git

don't append output book on failure
---

diff --git a/src/modules/rlm_test/rlm_test.c b/src/modules/rlm_test/rlm_test.c
index f65456a0fc..825b0628cd 100644
--- a/src/modules/rlm_test/rlm_test.c
+++ b/src/modules/rlm_test/rlm_test.c
@@ -353,15 +353,13 @@ static xlat_action_t trigger_test_xlat(TALLOC_CTX *ctx, fr_dcursor_t *out,
 	fr_value_box_t	*in_head = fr_value_box_list_head(in);
 	fr_value_box_t	*vb;
 
-	MEM(vb = fr_value_box_alloc(ctx, FR_TYPE_BOOL, NULL));
-	fr_dcursor_append(out, vb);
-
 	if (trigger(unlang_interpret_get(request), NULL, in_head->vb_strvalue, false, NULL) < 0) {
 		RPEDEBUG("Running trigger failed");
-		vb->vb_bool = false;
 		return XLAT_ACTION_FAIL;
 	}
 
+	MEM(vb = fr_value_box_alloc(ctx, FR_TYPE_BOOL, NULL));
+	fr_dcursor_append(out, vb);
 	vb->vb_bool = true;
 
 	return XLAT_ACTION_DONE;