From: Amos Jeffries <squid3@treenet.co.nz>
Date: Thu, 23 Feb 2017 10:02:10 +0000 (+1300)
Subject: Fix another Must(!= NULL) coverity issue.
X-Git-Tag: M-staged-PR71~249
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d39901ed7ef4e1bc36b25327e79e4bbb10972099;p=thirdparty%2Fsquid.git

Fix another Must(!= NULL) coverity issue.


The issue is that Coverity Scan gets confused by implicit casting of NULL
to a Pointer into thinking that 'true' comparison is possible when NULL
is involved. The != should still compile to the correct checks.

 Coverity Scan issue 1364725.
---

diff --git a/src/adaptation/icap/ModXact.cc b/src/adaptation/icap/ModXact.cc
index b09ee26bc7..b182b1b6c3 100644
--- a/src/adaptation/icap/ModXact.cc
+++ b/src/adaptation/icap/ModXact.cc
@@ -974,7 +974,7 @@ void Adaptation::Icap::ModXact::prepEchoing()
         } else if (dynamic_cast<const HttpReply*>(oldHead)) {
             newHead = new HttpReply;
         }
-        Must(newHead != NULL);
+        Must(newHead);
 
         newHead->inheritProperties(oldHead);