From: Ivana Hutarova Varekova <varekova@redhat.com>
Date: Fri, 11 Mar 2011 11:01:19 +0000 (+0100)
Subject: cgclassify: improve(unify) the usage output
X-Git-Tag: v0.38~119
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d3b20dad45f10fa3e9b3c2923dbdd093ea39920c;p=thirdparty%2Flibcgroup.git

cgclassify: improve(unify) the usage output

put the usage output to separate function

Signed-off-by: Ivana Hutarova Varekova <varekova@redhat.com>
Signed-off-by: Jan Safranek <jsafrane@redhat.com>
---

diff --git a/src/tools/cgclassify.c b/src/tools/cgclassify.c
index cdd6a9db..c27249ff 100644
--- a/src/tools/cgclassify.c
+++ b/src/tools/cgclassify.c
@@ -31,6 +31,20 @@
 
 #define TEMP_BUF	81
 
+static void usage(int status, const char *program_name)
+{
+	if (status != 0) {
+		fprintf(stderr, "Wrong input parameters,"
+			" try %s -h' for more information.\n",
+			program_name);
+	} else {
+		printf("usage is %s "
+			"[-g <list of controllers>:<relative path to cgroup>] "
+			"[--sticky | --cancel-sticky] <list of pids>  \n",
+			program_name);
+	}
+}
+
 /*
  * Change process group as specified on command line.
  */
@@ -110,10 +124,7 @@ int main(int argc, char *argv[])
 
 
 	if (argc < 2) {
-		fprintf(stderr, "usage is %s "
-			"[-g <list of controllers>:<relative path to cgroup>] "
-			"[--sticky | --cancel-sticky] <list of pids>  \n",
-			argv[0]);
+		usage(1, argv[0]);
 		exit(2);
 	}
 
@@ -137,7 +148,7 @@ int main(int argc, char *argv[])
 			flag |= CGROUP_DAEMON_CANCEL_UNCHANGE_PROCESS;
 			break;
 		default:
-			fprintf(stderr, "Invalid command line option\n");
+			usage(1, argv[0]);
 			exit(2);
 			break;
 		}