From: Christian Brauner <christian.brauner@ubuntu.com>
Date: Sun, 19 Aug 2018 17:41:00 +0000 (+0200)
Subject: cmd: use safe number parsers in lxc-usernsexec
X-Git-Tag: lxc-3.1.0~145^2~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d3b413e7d59e95219b054742cfb90b7cdade8b64;p=thirdparty%2Flxc.git

cmd: use safe number parsers in lxc-usernsexec

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
---

diff --git a/src/lxc/cmd/lxc_usernsexec.c b/src/lxc/cmd/lxc_usernsexec.c
index a2c518005..4909a9324 100644
--- a/src/lxc/cmd/lxc_usernsexec.c
+++ b/src/lxc/cmd/lxc_usernsexec.c
@@ -196,6 +196,7 @@ static int parse_map(char *map)
  */
 static int read_default_map(char *fnam, int which, char *user)
 {
+	int ret;
 	size_t len;
 	char *p1, *p2;
 	FILE *fin;
@@ -228,8 +229,20 @@ static int read_default_map(char *fnam, int which, char *user)
 			return -1;
 		}
 
-		newmap->hostid = atol(p1 + 1);
-		newmap->range = atol(p2 + 1);
+		ret = lxc_safe_ulong(p1 + 1, &newmap->hostid);
+		if (ret < 0) {
+			fclose(fin);
+			free(line);
+			return -1;
+		}
+
+		ret = lxc_safe_ulong(p2 + 1, &newmap->range);
+		if (ret < 0) {
+			fclose(fin);
+			free(line);
+			return -1;
+		}
+
 		newmap->nsid = 0;
 		newmap->idtype = which;