From: Pavel Filipenský <pfilipen@redhat.com>
Date: Wed, 11 May 2022 12:20:34 +0000 (+0200)
Subject: s3:smbd: Covscan: remove dead code
X-Git-Tag: talloc-2.3.4~129
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d3c678233c41e21d8c65f4ea0108a2046451367c;p=thirdparty%2Fsamba.git

s3:smbd: Covscan: remove dead code

Covscan:
source3/smbd/files.c:575: check_after_deref: Null-checking "fsp" suggests that it
may be null, but it has already been dereferenced on all paths leading to the check.

Signed-off-by: Pavel Filipenský <pfilipen@redhat.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat May 14 04:41:57 UTC 2022 on sn-devel-184
---

diff --git a/source3/smbd/files.c b/source3/smbd/files.c
index 894b90bbd15..7a41cff5654 100644
--- a/source3/smbd/files.c
+++ b/source3/smbd/files.c
@@ -598,9 +598,6 @@ fail:
 		  smb_fname_str_dbg(smb_fname),
 		  nt_errstr(status));
 
-	if (fsp == NULL) {
-		return status;
-	}
 	if (fsp_is_alternate_stream(fsp)) {
 		struct files_struct *tmp_base_fsp = fsp->base_fsp;