From: Fred Morcos <fred.morcos@open-xchange.com>
Date: Tue, 8 Aug 2023 14:36:14 +0000 (+0200)
Subject: Meson: Toplevel includes
X-Git-Tag: rec-5.1.0-alpha1~80^2~276
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d3e5677968d6b4a2a7b747784ec107e669db7a2a;p=thirdparty%2Fpdns.git

Meson: Toplevel includes
---

diff --git a/meson.build b/meson.build
index 5908b64f0f..b596e22401 100644
--- a/meson.build
+++ b/meson.build
@@ -97,6 +97,10 @@ if not fs.exists('docs' / 'pdns_server.1') and not python_have_venv
 endif
 # TODO Generate pdns_server.1 manpage
 
+# TODO Ultimately we should get rid of this by passing library objects instead of include
+# directories to e.g. modules.
+toplevel_includes = include_directories('.', 'pdns')
+
 # Modules
 all_modules = {
   'bind':     [],
@@ -118,7 +122,6 @@ foreach module_name, module_deps: all_modules
   module_backend_name = module_name + 'backend'
   module_opt = get_option('module-' + module_name)
   module_opt_dyn = get_option('module-' + module_name + '-dyn')
-  module_includes = include_directories('.', 'pdns')
 
   if module_name == 'remote' and (module_opt != 'disabled' or module_opt_dyn != 'disabled')
     set_variable(module_name + '_module', module_opt != 'disabled')
diff --git a/modules/bindbackend/meson.build b/modules/bindbackend/meson.build
index 3eac49ece4..3d9144c6c8 100644
--- a/modules/bindbackend/meson.build
+++ b/modules/bindbackend/meson.build
@@ -18,9 +18,9 @@ module_docs = [
 ]
 
 if get_variable(module_name + '_module')
-  static_library(module_backend_name, module_sources, include_directories: module_includes, dependencies: dep_libcrypto, extra_files: module_docs)
+  static_library(module_backend_name, module_sources, include_directories: toplevel_includes, dependencies: dep_libcrypto, extra_files: module_docs)
 endif
 
 if get_variable(module_name + '_dyn_module')
-  shared_library(module_backend_name, module_sources, include_directories: module_includes, dependencies: dep_libcrypto, extra_files: module_docs)
+  shared_library(module_backend_name, module_sources, include_directories: toplevel_includes, dependencies: dep_libcrypto, extra_files: module_docs)
 endif
diff --git a/modules/lua2backend/meson.build b/modules/lua2backend/meson.build
index e6e49181de..ea8a649b57 100644
--- a/modules/lua2backend/meson.build
+++ b/modules/lua2backend/meson.build
@@ -9,7 +9,7 @@ module_sources = [
 ]
 
 if get_variable(module_name + '_module')
-  static_library(module_backend_name, module_sources, include_directories: module_includes, dependencies: [dep_libcrypto, dep_lua])
+  static_library(module_backend_name, module_sources, include_directories: toplevel_includes, dependencies: [dep_libcrypto, dep_lua])
 endif
 
 if get_variable(module_name + '_dyn_module')