From: Frédéric Lécaille <flecaille@haproxy.com>
Date: Wed, 2 Jun 2021 13:36:12 +0000 (+0200)
Subject: MINOR: quic: Useless test in quic_update_ack_ranges_list()
X-Git-Tag: v2.5-dev8~129
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d3f4dd80141a2436eaddf5148179c88bcce924b0;p=thirdparty%2Fhaproxy.git

MINOR: quic: Useless test in quic_update_ack_ranges_list()

At this place, the condition "le_ar->first.key <= ar->first" is true because
<le_ar> is the ack-range just below <ar> ack range.
---

diff --git a/src/xprt_quic.c b/src/xprt_quic.c
index 7701f85ab0..c6b9a447f2 100644
--- a/src/xprt_quic.c
+++ b/src/xprt_quic.c
@@ -2329,7 +2329,7 @@ int quic_update_ack_ranges_list(struct quic_arngs *arngs,
 			eb64_entry(&le->node, struct quic_arng_node, first);
 
 		/* Already existing range */
-		if (le_ar->first.key <= ar->first && le_ar->last >= ar->last)
+		if (le_ar->last >= ar->last)
 			return 1;
 
 		if (le_ar->last + 1 >= ar->first) {