From: Marcin Siodelski <marcin@isc.org>
Date: Tue, 29 Jan 2019 20:17:29 +0000 (+0100)
Subject: [#396,!205] Add notes about using local time in CB functions.
X-Git-Tag: 429-Updated-StampedValue-to-support-reals_base~38
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d4095bbcb43acb01906690513a7c5eca215957ab;p=thirdparty%2Fkea.git

[#396,!205] Add notes about using local time in CB functions.
---

diff --git a/src/hooks/dhcp/mysql_cb/mysql_cb_dhcp4.h b/src/hooks/dhcp/mysql_cb/mysql_cb_dhcp4.h
index 7d501ee50d..16e5b4203d 100644
--- a/src/hooks/dhcp/mysql_cb/mysql_cb_dhcp4.h
+++ b/src/hooks/dhcp/mysql_cb/mysql_cb_dhcp4.h
@@ -1,4 +1,4 @@
-// Copyright (C) 2018 Internet Systems Consortium, Inc. ("ISC")
+// Copyright (C) 2018-2019 Internet Systems Consortium, Inc. ("ISC")
 //
 // This Source Code Form is subject to the terms of the Mozilla Public
 // License, v. 2.0. If a copy of the MPL was not distributed with this
@@ -18,6 +18,9 @@ class MySqlConfigBackendDHCPv4Impl;
 
 /// @brief Implementation of the MySql Configuration Backend for
 /// Kea DHCPv4 server.
+///
+/// All POSIX times specified in the methods belonging to this
+/// class must be local times.
 class MySqlConfigBackendDHCPv4 : public ConfigBackendDHCPv4 {
 public:
 
diff --git a/src/hooks/dhcp/mysql_cb/mysql_cb_impl.h b/src/hooks/dhcp/mysql_cb/mysql_cb_impl.h
index e9d891cc0d..fafc7f77df 100644
--- a/src/hooks/dhcp/mysql_cb/mysql_cb_impl.h
+++ b/src/hooks/dhcp/mysql_cb/mysql_cb_impl.h
@@ -28,6 +28,9 @@ namespace dhcp {
 ///
 /// This class contains common methods for manipulating data in the
 /// MySQL database, used by all servers.
+///
+/// All POSIX times specified in the methods belonging to this
+/// class must be local times.
 class MySqlConfigBackendImpl {
 protected:
 
diff --git a/src/lib/dhcpsrv/config_backend_dhcp4.h b/src/lib/dhcpsrv/config_backend_dhcp4.h
index fd6628d555..c0ae4eabb4 100644
--- a/src/lib/dhcpsrv/config_backend_dhcp4.h
+++ b/src/lib/dhcpsrv/config_backend_dhcp4.h
@@ -1,4 +1,4 @@
-// Copyright (C) 2018 Internet Systems Consortium, Inc. ("ISC")
+// Copyright (C) 2018-2019 Internet Systems Consortium, Inc. ("ISC")
 //
 // This Source Code Form is subject to the terms of the Mozilla Public
 // License, v. 2.0. If a copy of the MPL was not distributed with this
@@ -24,6 +24,9 @@ namespace isc {
 namespace dhcp {
 
 /// @brief Interface implemented by DHCPv4 configuration backends.
+///
+/// All POSIX times specified in the methods belonging to this
+/// class must be local times.
 class ConfigBackendDHCPv4 : public cb::BaseConfigBackend {
 public:
 
diff --git a/src/lib/dhcpsrv/config_backend_pool_dhcp4.h b/src/lib/dhcpsrv/config_backend_pool_dhcp4.h
index 6227602780..b2ea5dd585 100644
--- a/src/lib/dhcpsrv/config_backend_pool_dhcp4.h
+++ b/src/lib/dhcpsrv/config_backend_pool_dhcp4.h
@@ -1,4 +1,4 @@
-// Copyright (C) 2018 Internet Systems Consortium, Inc. ("ISC")
+// Copyright (C) 2018-2019 Internet Systems Consortium, Inc. ("ISC")
 //
 // This Source Code Form is subject to the terms of the Mozilla Public
 // License, v. 2.0. If a copy of the MPL was not distributed with this
@@ -24,6 +24,9 @@ namespace isc {
 namespace dhcp {
 
 /// @brief Implementation of the Configuration Backend Pool for DHCPv4.
+///
+/// All POSIX times specified in the methods belonging to this
+/// class must be local times.
 class ConfigBackendPoolDHCPv4 : public cb::BaseConfigBackendPool<ConfigBackendDHCPv4> {
 public: