From: Matthew DeVore <matvore@google.com>
Date: Fri, 7 Aug 2020 18:27:53 +0000 (-0700)
Subject: lib/util: do not make string_wrappers.h public
X-Git-Tag: talloc-2.3.2~685
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d485f369e92b5eb5c6482989c397a4eec29cd824;p=thirdparty%2Fsamba.git

lib/util: do not make string_wrappers.h public

string_wrappers.h is a collection of macros. All but one of the macros
rely on symbols not defined in public headers, so it is not useful as a
public header.

For instance, fstring is defined in includes.h. PTR_DIFF is defined in
lib/util/memory.h, which is not public.

checked_strlcpy is actually self-contained and is usable outside of a
Samba build, but without a Samba config.h, it is just aliased to
strlcpy.

Signed-off-by: Matthew DeVore <matvore@google.com>
Reviewed-by: David Mulder <dmulder@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/lib/util/wscript_build b/lib/util/wscript_build
index 0a730c17c88..7ae14130173 100644
--- a/lib/util/wscript_build
+++ b/lib/util/wscript_build
@@ -163,7 +163,6 @@ else:
                                  debug.h
                                  discard.h
                                  time.h
-                                 string_wrappers.h
                                  idtree.h
                                  idtree_random.h
                                  blocking.h