From: lpsolit%gmail.com <>
Date: Thu, 7 Aug 2008 02:56:23 +0000 (+0000)
Subject: Bug 449390: "Add Product" fails with software error "Column 'defaultmilestone' cannot... 
X-Git-Tag: bugzilla-3.3.1~248
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d4913056dbbbbdb236b1cfb0924205e08ae11260;p=thirdparty%2Fbugzilla.git

Bug 449390: "Add Product" fails with software error "Column 'defaultmilestone' cannot be null" - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat
---

diff --git a/Bugzilla/Product.pm b/Bugzilla/Product.pm
index e0a265b69a..febebfb0cc 100644
--- a/Bugzilla/Product.pm
+++ b/Bugzilla/Product.pm
@@ -347,7 +347,7 @@ sub _check_default_milestone {
 
     # Do nothing if target milestones are not in use.
     unless (Bugzilla->params->{'usetargetmilestone'}) {
-        return (ref $invocant) ? $invocant->default_milestone : undef;
+        return (ref $invocant) ? $invocant->default_milestone : '---';
     }
 
     $milestone = trim($milestone);
@@ -371,10 +371,10 @@ sub _check_milestone_url {
 
     # Do nothing if target milestones are not in use.
     unless (Bugzilla->params->{'usetargetmilestone'}) {
-        return (ref $invocant) ? $invocant->milestone_url : undef;
+        return (ref $invocant) ? $invocant->milestone_url : '';
     }
 
-    $url = trim($url);
+    $url = trim($url || '');
     return $url;
 }